Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update assert #2799

Merged
merged 11 commits into from
Apr 7, 2023
Merged

Update assert #2799

merged 11 commits into from
Apr 7, 2023

Conversation

maddieford
Copy link
Contributor

Description

Update test_download_fail assertion to look for current agent version, instead of always looking for 9.9.9.9

Issue #

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #2799 (46a129a) into develop (1601e88) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2799   +/-   ##
========================================
  Coverage    72.02%   72.02%           
========================================
  Files          104      104           
  Lines        15870    15870           
  Branches      2273     2273           
========================================
  Hits         11430    11430           
  Misses        3916     3916           
  Partials       524      524

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@maddieford maddieford merged commit c89647c into Azure:develop Apr 7, 2023
@maddieford maddieford deleted the update-assert branch August 30, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narrieta narrieta narrieta approved these changes

@nagworld9 nagworld9 nagworld9 approved these changes

@ZhidongPeng ZhidongPeng Awaiting requested review from ZhidongPeng ZhidongPeng is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maddieford @narrieta @nagworld9